[WIP] Introduce priority queue-based policy again... again #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johntyree
changed the title
johntyree
force-pushed
the
enh/priority-policy-2
branch
from
48ef5cc
to
2246ad0
Compare
…er into enh/priority-policy-2
|
Right now, our error messages depend on the path that the solver takes through the search space. This means that any test involving error messages is likely to fail for one policy or the other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off of #130 and should be merged after that one.
This is a remake of #81, which itself is a remake of #65 and #55.
This introduces the PriorityQueuePolicy again. It has good and bad qualities in comparison with the
UndeterminedClausePolicy. It doesn't always produce the same results, but there's no reason to say that that policy is producing optimal results in the first place. They have comparable speed. On the slow scenarioslow_bokeh_blaze.yaml, it's about 20% faster. However, when running the test suite, it's about 20% slower.I think it has the potential to be more flexible than what we have now, but since we don't really know what the optimal way to suggest packages is I'm not sure if that's useful yet.
That all said, it's good to have a second implementation to keep things in perspective. I'll modify the tests such that they run for both policies, regardless of what we choose for a default.
TODO: